On 10/29/2015 11:39 PM, Andi Kleen wrote:
David Malcolm <dmalc...@redhat.com> writes:

   * adds -Wmisleading-indentation to -Wall

I have doubts this is a good idea. I'm sure this will break
a bazillion packages which (misguidedly) ship with -Wall -Werror.

Would be better to leave the user the choice, given that such a thing
was historically never checked before and not include it in -Wall.
The same could be said for ever adding stuff to -Wall. Hell, I've taken arrows for changes in -Wall for decades. That doesn't mean we should lock down -Wall for those misguided projects.

As I stated in my approval message, we'll have to watch for real world fallout and if it's bad, reevaluate.

jeff

Reply via email to