On 10/05/2015 05:40 PM, Mikhail Maltsev wrote:
gcc/ChangeLog:

2015-10-05  Mikhail Maltsev  <malts...@gmail.com>

        * config/alpha/alpha.c (alpha_function_arg): Use gcc_checking_assert.
        * config/arm/arm.c (arm_unwind_emit_sequence): Adjust to use CHECKING_P.
        * config/bfin/bfin.c (hwloop_optimize): Likewise.
        * config/i386/i386.c (ix86_print_operand_address,
        output_387_binary_op): Likewise.
        * config/ia64/ia64.c (ia64_sched_init, bundling): Likewise.
        * config/m68k/m68k.c (m68k_sched_md_init_global): Likewise.
        * config/rs6000/rs6000.c (htm_expand_builtin, rs6000_emit_prologue):
        Likewise.
        * config/rs6000/rs6000.h: Likewise.
        * config/visium/visium.c (visium_setup_incoming_varargs): Likewise.

I think I remember why some stuff was left with a #if rather than converting to if (flag_checking) -- formatting.

I believe Mikhail mentioned he left some things as #if that would have required reformatting if turned into a runtime conditional. I believe I said that was initially OK, but would need to be fixed. After all it's just formatting.

From looking at this patch, the only one that's at all painful is the ia64 bits. I can see what the code is doing and pretty sure I can convert it correctly, but would suggest we do so as a separate follow-up -- where we'll allocate a beaker box so we can bootstrap test it for deeper testing than we get from config-list.mk.


Jeff

Reply via email to