On 10/27/15 01:18, Jakub Jelinek wrote:
LGTM, though could I ask you to try to try to move the struct oacc_collapse expand_oacc_collapse_init expand_oacc_collapse_vars expand_oacc_for additions somewhere else (e.g. in between expand_omp_taskreg and expand_omp_for_init_counts),
ok, I wasn't sure of the best placement.
because it seems patch just got too confused and gave up, so most of expand_omp_for which I assume is unchanged except for+ else if (gimple_omp_for_kind (fd.for_stmt) == GF_OMP_FOR_KIND_OACC_LOOP) + { + gcc_assert (!inner_stmt); + expand_oacc_for (region, &fd); + }addition is considered to be deleted in one place and added into another one; if patch does this, I'd be afraid svn blame or git blame would do so too, and thus lose history for expand_omp_for. If moving it around doesn't help, no big deal, but if it helps, it would be appreciated.
yeah, I noticed diff got confused. (I'm not sure the above suggestion will resolve it, but we can give it a go.
nathan
