Re: [testsuite, committed, PR68063] Add missing private clause in libgomp.c++/member-2.C

[Thomas Schwinge]

Hi!

On Tue, 27 Oct 2015 11:08:15 +0100, Jakub Jelinek <ja...@redhat.com> wrote:
> On Tue, Oct 27, 2015 at 10:15:11AM +0100, Thomas Schwinge wrote:
> > ... looks a bit as if it might need to get the same patch applied that
> > Tom has applied to libgomp.c++/member-2.C:
> 
> You're right, member-2.C is a templatized version of member-1.C,
> a change to add private (R::r) to that corresponding member-1.C taskloop
> directive is preapproved.

Tested, and committed in r229411:

commit 540c8b2a12162472a4f644b7b533041a813a0332
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Tue Oct 27 10:32:32 2015 +0000

    [PR testsuite/68063] Add missing private clause in libgomp.c++/member-1.C
    
        PR testsuite/68063
        * testsuite/libgomp.c++/member-1.C (A::m1): Add missing private clause.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@229411 
138bc75d-0d04-0410-961f-82ee72b054a4
---
 libgomp/ChangeLog                        | 5 +++++
 libgomp/testsuite/libgomp.c++/member-1.C | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git libgomp/ChangeLog libgomp/ChangeLog
index ca34af8..0194503 100644
--- libgomp/ChangeLog
+++ libgomp/ChangeLog
@@ -1,3 +1,8 @@
+2015-10-27  Thomas Schwinge  <tho...@codesourcery.com>
+
+       PR testsuite/68063
+       * testsuite/libgomp.c++/member-1.C (A::m1): Add missing private clause.
+
 2015-10-27  James Norris  <jnor...@codesourcery.com>
 
        * testsuite/libgomp.oacc-c-c++-common/combdir-1.c: New file.
diff --git libgomp/testsuite/libgomp.c++/member-1.C 
libgomp/testsuite/libgomp.c++/member-1.C
index d2d0c5b..c7c1ba4 100644
--- libgomp/testsuite/libgomp.c++/member-1.C
+++ libgomp/testsuite/libgomp.c++/member-1.C
@@ -151,7 +151,7 @@ A::m1 ()
     {
       f = false;
     #pragma omp single
-    #pragma omp taskloop lastprivate (a, t, b, n)
+    #pragma omp taskloop lastprivate (a, t, b, n) private (R::r)
       for (int i = 0; i < 30; i++)
        {
          int q = omp_get_thread_num ();


Grüße
 Thomas

signature.asc
Description: PGP signature