On Mon, Oct 26, 2015 at 09:13:28AM -0700, Nathan Sidwell wrote:
> On 10/26/15 08:13, Jakub Jelinek wrote:
> 
> >>It won't convert them into such representations.
> >
> >Can you fix that incrementally?  I'd expect that code marked with acc loop 
> >vector
> >can't have loop carried backward lexical dependencies, at least not within
> >the adjacent number of iterations specified in vector clause?
> 
> Sure.  I was using 'won't' to  describe the patch,  not claiming it could
> never be changed to do that kind of thing.

Ok.

> >Otherwise LGTM.
> 
> I think all your other comments are spot on and will address.  Do you want
> another review with them fixed?

Just committing fixed version (and posting what you've committed for patches
that changed since the patch that has been posted earlier) is enough.

> If not, I think the  only thing remaining is  the IFN_UNIQUE patch, which
> (At least) needs an update to use targetm.have... conversion.

Ok, will wait till you make those changes then?

        Jakub

Reply via email to