On Sat, Oct 24, 2015 at 12:29 AM, Ilya Enkovich <enkovich....@gmail.com> wrote: > 2015-10-24 0:32 GMT+03:00 Jeff Law <l...@redhat.com>: >> On 10/23/2015 09:26 AM, Ilya Enkovich wrote: >>> >>> Hi, >>> >>> This patch checks optab exists before using it vector vector statement >>> lowering. It fixes compilation of test from PR68062 with -funsigned-char >>> option added (doesn't fix original testcase). Bootstrapped for >>> x86_64-unknown-linux-gnu. OK for trunk if no regressions? >>> >>> Thanks, >>> Ilya >>> -- >>> gcc/ >>> >>> 2015-10-23 Ilya Enkovich <enkovich....@gmail.com> >>> >>> * tree-vect-generic.c (expand_vector_operations_1): Check >>> optab exists before use it. >>> >>> gcc/testsuite/ >>> >>> 2015-10-23 Ilya Enkovich <enkovich....@gmail.com> >>> >>> * g++.dg/pr68062.C: New test. >> >> OK. >> >> Just curious, what was the tree code for which we couldn't find a suitable >> optab? > > Those are various comparison codes.
Yeah, sorry for missing that check. Btw, I was curious to see that we miss a way to query from optab_tag the "kind" (normal, conversion, etc.) so code can decide what optab_handler function to call (optab_handler or convert_optab_handler). So the code I added errs on the "simplistic" side and hopes that matching lhs and rhs1 type always gets us a non-convert optab... Richard. > Ilya > >> >> jeff >>
