On Fri, 23 Oct 2015, Kirill Yukhin wrote:
> > You need to update this patch to take account of Marek's fix for bug 67964
> > (it was because I was suspicious of the "continue;" in this patch
> > accepting invalid syntax that I found that bug), retest and resubmit.
> I've rebased the patch on top of current trunk.
This isn't taking proper account of Marek's fix.
> @@ -3993,6 +4001,12 @@ c_parser_attributes (c_parser *parser)
> break;
> continue;
> }
> + if (is_attribute_p ("simd", attr_name))
> + {
> + parser->simd_attr_present = 1;
> + c_parser_consume_token (parser);
> + continue;
> + }
Any such continue needs first to break if the next token isn't a comma;
otherwise you accept bad syntax with no comma between successive
attributes.
--
Joseph S. Myers
jos...@codesourcery.com
