On 10/18/2015 08:17 AM, Mikhail Maltsev wrote:
On 10/12/2015 11:57 PM, Jeff Law wrote:
-#ifdef ENABLE_CHECKING
+#if CHECKING_P
I fail to see the point of this change.
I'm guessing (and Mikhail, please correct me if I'm wrong), but I think he's
trying to get away from ENABLE_CHECKING and instead use a macro which is
always defined to a value.
Yes, exactly. Such macro is better because it can be used both for conditional
compilation (if needed) and normal if-s (unlike ENABLE_CHECKING).
But for normal C conditions the patches end up using flag_checking, so
the CHECKING_P macro buys us nothing over ENABLE_CHECKING. A change like
this is just churn: changing things without making forward progress, and
every change like that will cause someone else grief when they have to
adjust their own out-of-tree patches. (It's something I think we've been
doing too much lately, and others have complained to me about this issue
as well).
I'm ok with pretty much all of the rest of the changes (some minor
comments to follow), so if you could eliminate CHECKING_P I'd be likely
to approve them.
Bernd
