On 10/17/2015 08:57 AM, Mikhail Maltsev wrote:
On 10/06/2015 04:46 PM, Jason Merrill wrote:
Hi, sorry for the slow response.  Please feel free to ping once a week.

On 08/27/2015 02:27 PM, Mikhail Maltsev wrote:
+  if (TREE_THIS_VOLATILE (t) && (!DECL_P (t) || want_rval))

Why the !DECL_P check?  Pulling the value out of a volatile INDIRECT_REF is just
as problematic as from a variable.

Hmm... my intent was to check that we are not dealing with an expression, i.e.
that should have been 'EXPR_P' rather than '!DECL_P'.

But why do you want to check that? My point is that the same issue can occur with an expression. Can't you just check want_rval?

But now I wonder, if the combination 'TREE_THIS_VOLATILE (t) && EXPR_P (t) &&
!want_rval' is possible at all and should it be rejected?

It is possible for a volatile *_REF.

Jason

Reply via email to