On Fri, 2015-10-16 at 15:47 +0100, Marcus Shawcroft wrote:
> On 16 October 2015 at 15:31, Benedikt Huber
> <benedikt.hu...@theobroma-systems.com> wrote:
> > I introduced this in revision 7 due to a request from James Greenhalgh.
> > https://gcc.gnu.org/ml/gcc-patches/2015-10/msg00963.html
> >
> >> Given that this is all so mechanical, I'd have a preference towards
> >> refactoring this to loop over some structured data.
> >
> > Do you mean, that I should get rid of the typedef and leave the struct
> > without it?
> > Or should I completely drop the struct?
>
> The use of the struct is fine, we are being discouraged from using
> unnecessary typedefs. Just rewrite it as:
>
> struct builtin_decls_data
> {
> ...
> };
>
Yes, that's what I meant. Also things like
> +void
> +aarch64_emit_swrsqrt (rtx dst, rtx src)
> +{
> + enum machine_mode mode = GET_MODE (src);
> + gcc_assert (
> + mode == SFmode || mode == V2SFmode || mode == V4SFmode
> + || mode == DFmode || mode == V2DFmode);
Instead of "enum machine_mode" use "machine_mode". Similarly, for
"struct bleh*" use "bleh*". Although it seems there are no occurrences
of the latter in your patch.
Cheers,
Oleg
