On Thu, Oct 15, 2015 at 11:47:10AM +0200, Bernd Schmidt wrote: > On 10/15/2015 04:13 AM, Trevor Saunders wrote: > >On Mon, Oct 12, 2015 at 12:19:08PM +0200, Bernd Schmidt wrote: > >>If we go to the trouble of changing this, could we convert macros to target > >>hooks instead while we're there? REVERSE_CONDITION, SETUP_FRAME_ADDRESSES > >>and FRAME_ADDR_RTX all seem to be used only in a handful of ports, and > >>INITIAL_FRAME_ADDRESS_RTX only in one. > > > >I'm definitely planning to do that, but I think this is still somewhat > >useful even if only to have one list to look at for what hooks need to > >be added. > > I'd prefer to do things right from the start, at least for easy cases such > as these. Each change we make has a chance of introducing errors, and there > is a cost for people working on patches each time the code changes under > them. And for you it'll be less work in the long run as well.
Its a fair concern that changing things has risks, on the other hand breaking the change up into parts makes the parts simpler to check for correctness. At any rate I don't have any more tiny patches like this coming, so I don't know how much this discussion is getting us ;) thanks! Trev > > > Bernd