On Tue, Oct 13, 2015 at 02:18:41PM +0300, Maxim Ostapenko wrote:
> This is a reapplied Jakub's patch for disabling ODR violation detection.
> More details can be found here
> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63888).
This is ok when all the other changes are acked.
> 2015-10-12 Maxim Ostapenko <m.ostape...@partner.samsung.com>
>
> PR bootstrap/63888
> Reapply:
> 2015-02-20 Jakub Jelinek <ja...@redhat.com>
>
> * asan/asan_globals.cc (RegisterGlobal): Disable detect_odr_violation
> support until it is rewritten upstream.
>
> * c-c++-common/asan/pr63888.c: New test.
>
> Index: libsanitizer/asan/asan_globals.cc
> ===================================================================
> --- libsanitizer/asan/asan_globals.cc (revision 250059)
> +++ libsanitizer/asan/asan_globals.cc (working copy)
> @@ -146,7 +146,9 @@
> CHECK(AddrIsInMem(g->beg));
> CHECK(AddrIsAlignedByGranularity(g->beg));
> CHECK(AddrIsAlignedByGranularity(g->size_with_redzone));
> - if (flags()->detect_odr_violation) {
> + // This "ODR violation" detection is fundamentally incompatible with
> + // how GCC registers globals. Disable as useless until rewritten upstream.
> + if (0 && flags()->detect_odr_violation) {
> // Try detecting ODR (One Definition Rule) violation, i.e. the situation
> // where two globals with the same name are defined in different modules.
> if (__asan_region_is_poisoned(g->beg, g->size_with_redzone)) {
Jakub
