On 10/10/2015 01:58 PM, Tom de Vries wrote:
Handle original loop tree in expand_omp_for_generic
2015-09-10 Tom de Vries<t...@codesourcery.com>
PR tree-optimization/67476
* omp-low.c (expand_omp_for_generic): Handle original loop tree.
This one I find slightly confusing.
- add_bb_to_loop (l2_bb, cont_bb->loop_father);
+ struct loop *loop = l1_bb->loop_father;
+ add_bb_to_loop (l2_bb, entry_bb->loop_father);
add_loop (outer_loop, l0_bb->loop_father);
Looks like a lot of bb's loop_father is being looked at. Are all or some
of these supposed to be the same? I think I'd like one (appropriately
named) struct loop * variable for each loop that's involved here.
There's a comment suggesting that there can be different situations, it
would be good to expand that to explain how they can arise.
- struct loop *loop = alloc_loop ();
+ loop = alloc_loop ();
Also, I think it would be preferrable to not reuse that loop variable
but make a new one instead.
Bernd
