> -----Original Message-----
> From: Steve Ellcey [mailto:sell...@imgtec.com]
> Sent: Tuesday, October 06, 2015 6:03 PM
> To: Moore, Catherine
> Cc: Matthew Fortune; GCC Patches
> Subject: RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI
> 
> On Tue, 2015-10-06 at 12:02 +0000, Moore, Catherine wrote:
> 
> > > Moore, Catherine <catherine_mo...@mentor.com> writes:
> > > > The patch itself looks good, but the tests that you added need a little
> more
> > > work.
> 
> Here is a new patch for just the tests.  I added NOMIPS16 and the
> -mabi=32 flag as Matthew suggested and I also added -mno-abicalls.
> 
> Without the -mno-abicalls the MIPS linux compiler defaulted to
> -mabicalls and allocated 32 bytes without the optimization and the MIPS
> elf compiler defaulted to -mno-abicalls and allocated 24 bytes without
> the optimization.  This synchronizes them so they both allocate 24 bytes
> without the optimization and 8 bytes with it.  Everything should pass
> now, it passed for me using mips-mti-linux-gnu and mips-mti-elf.
> 
> Steve Ellcey
> sell...@imgtec.com
> 
> 
> 2015-10-06  Steve Ellcey  <sell...@imgtec.com>
> 
>       * gcc.target/mips/mips.exp (mips_option_groups): Add -mframe-
> header-opt
>       and -mno-frame-header-opt options.
>       * gcc.target/mips/frame-header-1.c: New file.
>       * gcc.target/mips/frame-header-2.c: New file.
>       * gcc.target/mips/frame-header-3.c: New file.
> 
> 
This looks good to go now.
Thanks,
Catherine

Reply via email to