Thanks for working on this, Simon! On 01/10/15 15:43, Simon Dardis wrote:
-(define_expand "reduc_smax_<mode>" - [(match_operand:VWHB 0 "register_operand" "") - (match_operand:VWHB 1 "register_operand" "")] +(define_expand "reduc_smax_scal_<mode>" + [(match_operand:HI 0 "register_operand" "") + (match_operand:VH 1 "register_operand" "")]
-(define_expand "reduc_smin_<mode>" - [(match_operand:VWHB 0 "register_operand" "") - (match_operand:VWHB 1 "register_operand" "")] +(define_expand "reduc_smin_scal_<mode>" + [(match_operand:HI 0 "register_operand" "") + (match_operand:VH 1 "register_operand" "")]
I note these two change from VWHB to VH; the latter is just V4HI, so this loses you smin/smax for V2SI and V8QI...is that intentional? (It looks like you define vec_loongson_extract_lo for all relevant modes so I would expect you to use <V_inner> as you do for reduc_plus_scal.)
(In contrast umax/umin only had VB = V8QI variants before.) Also a minor stylistic point:
+ emit_insn ( gen_vec_loongson_extract_lo_<mode> (operands[0], tmp));
(Five instances) spurious space after (. Cheers, Alan
