Hi! On Fri, 18 Sep 2015 10:11:25 +0200, I wrote: > On Fri, 17 Jul 2015 11:13:59 -0700, Cesar Philippidis > <ce...@codesourcery.com> wrote: > > This patch updates the libgomp OpenACC reduction test cases [...] > > > --- a/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90 > > +++ b/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90
> With -O0, I frequently see this test FAIL (thus XFAILed), both for nvptx > offloading and host-fallback execution. Adding a few printfs, I observe > redsub_gang compute "random" results. This seems to have gotten fixed with Nathan's recent "Another oacc reduction simplification", <http://news.gmane.org/find-root.php?message_id=%3C560173E1.9030801%40acm.org%3E>, so I'm removing the XFAIL. The following issue however remains to be addressed: > Given the following > -Wuninitialized/-Wmaybe-uninitialized warnings (for -O1, for example), > maybe there's some initialization of (internal) variables missing? > (These user-visible warnings about compiler internals need to be > addressed regardless.) Would you please have a look at that? > > source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90: In > function 'redsub_combined_._omp_fn.0': > source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90:73:0: > warning: '<anonymous>' is used uninitialized in this function > [-Wuninitialized] > !$acc loop reduction(+:sum) gang worker vector > ^ > source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90: In > function 'redsub_vector_._omp_fn.1': > source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90:60:0: > warning: '<anonymous>' is used uninitialized in this function > [-Wuninitialized] > !$acc loop reduction(+:sum) vector > ^ > source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90: In > function 'redsub_worker_._omp_fn.2': > source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90:47:0: > warning: '<anonymous>' is used uninitialized in this function > [-Wuninitialized] > !$acc loop reduction(+:sum) worker > ^ > source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90: In > function 'redsub_gang_._omp_fn.3': > source-gcc/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90:34:0: > warning: 'sum.43' may be used uninitialized in this function > [-Wmaybe-uninitialized] > !$acc loop reduction(+:sum) gang > ^ Committed to gomp-4_0-branch in r228035: commit 705169947333655ded3427985b34b758a5bc6cf5 Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4> Date: Wed Sep 23 07:54:15 2015 +0000 Remove XFAIL of OpenACC reduction execution test case for -O0 libgomp/ * testsuite/libgomp.oacc-fortran/reduction-5.f90: Remove XFAIL of execution test for -O0. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@228035 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog.gomp | 5 +++++ libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90 | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git libgomp/ChangeLog.gomp libgomp/ChangeLog.gomp index 46c1a05..47db0d4 100644 --- libgomp/ChangeLog.gomp +++ libgomp/ChangeLog.gomp @@ -1,3 +1,8 @@ +2015-09-23 Thomas Schwinge <tho...@codesourcery.com> + + * testsuite/libgomp.oacc-fortran/reduction-5.f90: Remove XFAIL of + execution test for -O0. + 2015-09-22 Cesar Philippidis <ce...@codesourcery.com> * testsuite/libgomp.oacc-fortran/dummy-array.f90: New test. diff --git libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90 libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90 index f787e7d..180c9a2 100644 --- libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90 +++ libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90 @@ -1,5 +1,4 @@ ! { dg-do run } -! { dg-xfail-run-if "TODO" { *-*-* } { "-O0" } } ! subroutine reduction Grüße, Thomas
signature.asc
Description: PGP signature
