On 21 September 2015 at 12:55, Christian Bruel <christian.br...@st.com> wrote: > Hi Christophe, > >> It seems you committed the 1st version of your patch. > > > Not sure what version you are talking about. I committed what was posted > (https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01260.html) at revision > #227880.
I thought you had modified it, after Richard's comments. > >> However, it fails if one forces a armv5t target, because, as Richard >> said -mfloat-abi=hard is not supported on Thumb1. > > > sure, but the testcase was for thumb2. It's just that the thumb1 check in > the dg-skip-if is indeed useless. I'll fix this. > >> >> It tried to remove -mfloat-abi=hard, and I noticed that only 1 'blx' >> is generated when using soft or softfp. >> >> I expect this to be fixed by the linker anyway, but it may mean there >> is still something wrong. > > > This is expected. For thumb1, such static calls interwork are still done by > the linker. > For consistency IMHO we could also resolve static interwork thumb1 calls in > the compiler, but that would be another issue. > This failure was only for thumb2 (this having -march=armv7-a in the > dg-options). (See https://sourceware.org/bugzilla/show_bug.cgi?id=17505) > > Hope that clarifies, > Yes, thanks. > thanks > > Christian
