On Thu, Sep 17, 2015 at 7:08 AM, David Edelsohn <dje....@gmail.com> wrote:
> On Wed, Sep 9, 2015 at 12:12 AM, Ian Lance Taylor <i...@airs.com> wrote:
>> Mike Stump <mikest...@comcast.net> writes:
>>
>>> Not a big issue, but slightly better if (O_CLOEXEC>>32) != 0 is also
>>> true.  See, if AIX should ever define this to a sensible value, the
>>> above would disappear the feature.  However, if they did, then this
>>> expression should then be false.
>>
>> Yes, I think this might be even better in code.  How about something
>> like
>>
>>   /* On some versions of AIX O_CLOEXEC does not fit in int, so use a
>>      cast to force it.  */
>>   descriptor = open (filename, (int) (O_RDONLY | O_BINARY | O_CLOEXEC));
>>
>> Does that work on AIX?
>
> Any decision about this patch?

This patch is OK if it works.

Ian

Reply via email to