On 09/09/2015 04:33 PM, Mark Wielaard wrote:
On Thu, 2015-09-10 at 00:03 +0200, Jakub Jelinek wrote:
On Wed, Sep 09, 2015 at 04:01:07PM -0600, Jeff Law wrote:
* gcc.dg/nonnull-4.c: New test.
* g++.dg/warn/nonnull3.C: Likewise.
If the tests are the same, perhaps stick just one test into
c-c++-common/nonnull-1.c instead?
Yes, that would be better. The warnings should be exactly the same.
Also, all the "cp1 compared to NULL"
strings mention cp1, did you mean the second one to mention cp2 and so on?
Oops. copy/paste error indeed.
Can you also upate the -Wnonnull documentation in invoke.texi to indicate it
also will warn if it discovers a non-null argument that is compared against
null?
With the doc fix and a bootstrap/regression test, this patch ought to be
fine.
Documentation added. bootstrap/regression test still running.
Updated patch attached.
Assuming the bootstrap & regression test completed without errors, this
patch is fine for the trunk. Please install if you haven't done so already.
jeff