On Mon, Sep 07, 2015 at 05:46:12PM +0300, Ilya Verbin wrote:
> On Sat, Sep 05, 2015 at 00:45:36 +0300, Ilya Verbin wrote:
> > 2015-09-04 22:27 GMT+03:00 Mike Stump <mikest...@comcast.net>:
> > > On Sep 4, 2015, at 4:10 AM, Hahnfeld, Jonas <hahnf...@itc.rwth-aachen.de>
> > > wrote:
> > >>>>> * intelmic-mkoffload.c (prepare_target_image): Fix if the temp path
> > >>>>> contains a '-‘.
> > >
> > > So, out of curiosity, did you test all characters other than null? If -
> > > doesn’t work, there is a good chance that no such test has been done, and
> > > there is a small hoard of bugs, all the same in there.
> >
> > Good point. Objcopy in bfd/binary.c creates symbol names this way:
> >
> > for (p = buf; *p; p++)
> > if (! ISALNUM (*p))
> > *p = '_';
> >
> > We should do the same in intelmic-mkoffload.c. I will prepare a patch.
>
> gcc/
> * config/i386/intelmic-mkoffload.c (prepare_target_image): Handle all
> non-alphanumeric characters in the symbol name.
>
> Regtested on x86_64-linux. OK for trunk? OK for gcc-5-branch?
Ok for both.
Jakub
