On 08/25/2015 05:06 AM, Alan Lawrence wrote:
I used this as a means of better-testing the previous changes, as it exercises
the constant replacement code a whole lot more. Indeed, quite a few tests are
now optimized away to nothing on AArch64...
Always pulling in constants, is almost certainly not what we want, but we may
nonetheless want something more aggressive than the usual --param, e.g. for the
ssa-dom-cse-2.c test. Thoughts welcomed?
I'm of the opinion that we have too many knobs already. So I'd perhaps
ask whether or not this option is likely to be useful to end users?
As for the patch itself, any thoughts on reasonable heuristics for when
to pull in the constants? Clearly we don't want the patch as-is, but
are there cases we can identify when we want to be more aggressive?
jeff