On Mon, Aug 24, 2015 at 9:04 AM, Marek Polacek <pola...@redhat.com> wrote: > On Mon, Aug 24, 2015 at 08:18:41AM -0700, Ian Lance Taylor wrote: >> On Mon, Aug 24, 2015 at 4:34 AM, Marek Polacek <pola...@redhat.com> wrote: >> > >> > This is hopefully the last attempt to fix the libgo breakage. This time >> > around I really think I got to the bottom of the problem. The issue is >> > that the Go FE defines the __builtin_trap call, but doesn't set the >> > TREE_THIS_VOLATILE flag on it. That's bad because then this call isn't >> > gimple_call_noreturn_p and the cgraph cleanup code can't do its job >> > properly. >> > >> > Bootstrapped/regtested on x86_64-linux. Now, I don't know the Go patch >> > process here. Should I just wait for you Ian to commit the patch? >> > (Yeah, I think I don't need the ChangeLog entry.) >> >> For files in gcc/go/gofrontend, you should wait for me to commit the >> path. This file is in gcc/go, not gcc/go/gofrontend, so you can >> commit the patch directly, with a ChangeLog entry. (I know it's >> confusing.) > > I see, thanks. > >> I would rather not see a default value for this parameter. I would >> rather see all the calls change to pass false. As the GCC coding >> conventions say, one should normally avoid default arguments >> (https://gcc.gnu.org/codingconventions.html#Default). > > Ok, adjusted. > >> This patch is OK with that change. > > Thanks and sorry for the breakage.
No need to apologize, it was my bug. Thanks for finding and fixing it. Ian
