On Sun, Aug 23, 2015 at 11:14 PM, FX <fxcoud...@gmail.com> wrote:
>
>> Awesome! Looks good. I only have one small bikeshed request: Can you
>> make the output format match the existing code?
>
> Problem with that is that ad the new backtrace uses full path for file names,
> the one-line format easily wraps in 80 column and make the output harder to
> read (in my opinion).
>
> In realize this is mostly taste an very subjective, so with this nugget of
> extra input, I leave the final decision to you: let me know what you think
> best, between readability and "conformance" to GDB format.
Ah, I didn't realize that. I guess you're right, it's better to split
the filename:linenumber to a separate line. But still, I think it's
clearer if you keep the "in" and "at" like the current code & gdb
does. Thus, something like
#framenumber 0xADDRESS in funcname
at filename:linenumber
And another thing which I previously missed: You have removed the
store_exe_path function as it's no longer used for anything. However,
that function is part of the libgfortran ABI and is found in
gfortran.map, so we have to keep it until we bump the so version. :(
Please also add a note to the libgfortran ABI cleanup wiki page so we
don't forget about it.
With these changes, Ok for trunk. Thanks a lot for working on this!
--
Janne Blomqvist
