Hi, On Wed, 27 Jul 2011, William J. Schmidt wrote:
> +static long
> +propagate_rank (long rank, tree op)
> +{
> + long phi_prop_rank = phi_propagation_rank (op);
> +
> + if (phi_prop_rank)
> + return MAX (rank, phi_prop_rank);
> +
> + return MAX (rank, get_rank (op));
> +}
I know it's pre-existing code, but as you're touching it anyway: function
calls in min/max macros usually are a bad idea due to multiple
evaluations. If nothing else it's just wasted work.
Ciao,
Michael.
