Kyrill Tkachov <kyrylo.tkac...@arm.com> writes:
>> 015-08-20 Christian Bruel<christian.br...@st.com>
>>
>> * gcc.dg/Wno-frame-address.c: Skip for ARM.
>> * g++.dg/Wno-frame-address.C: Ditto.
>>
>> Index: gcc/testsuite/gcc.dg/Wno-frame-address.c
>> ===================================================================
>> --- gcc/testsuite/gcc.dg/Wno-frame-address.c (revision 227030)
>> +++ gcc/testsuite/gcc.dg/Wno-frame-address.c (working copy)
>> @@ -1,4 +1,5 @@
>> /* { dg-do compile } */
>> +/* { dg-skip-if "Cannot access arbitrary stack frames. " { arm*-*-* } { "*"
>> } { "" } } */
>> /* { dg-options "-Werror" } */
>> /* Verify that -Wframe-address is not enabled by default by enabling
>> Index: gcc/testsuite/g++.dg/Wno-frame-address.C
>> ===================================================================
>> --- gcc/testsuite/g++.dg/Wno-frame-address.C (revision 227030)
>> +++ gcc/testsuite/g++.dg/Wno-frame-address.C (working copy)
>> @@ -1,4 +1,5 @@
>> // { dg-do compile }
>> +/* { dg-skip-if "Cannot access arbitrary stack frames. " { arm*-*-* } { "*"
>> } { "" } } */
>> // { dg-options "-Werror" }
>
> Use the C++-style comment here.
> Otherwise looks ok to me, though if more tests like this crop we'd want a
> dg-requires-effective-target check that filters out the targets that don't
> implement this feature.
Besides: omit the blank after the `frames. ' in the dg-skip-if comment
and the unnecessary default arguments ({ "*" } { "" }) in both cases.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
