Hi! On Mon, 10 Aug 2015 21:50:21 +0200, I wrote: > On Mon, 3 Aug 2015 10:30:49 -0400, Nathan Sidwell <nat...@acm.org> wrote: > > I've committed this patch to gomp4. The existing implementation of > > firstprivate > > presumes the existence of memory at the CTA level. This patch does away > > with > > that, treating firstprivate as thread-private variables initialized from > > the > > host. > > > > During development there was some fallout from declare handling, as that > > wasn't > > creating the expected omp_region context object. The previous handling > > of > > firstprivate just happened to work. Jim has been working on resolving that > > problem. > > I'm seeing the following regressions after this r226508 commit -- are > those the ones that Jim is working on resolving?
With Jim's recent commit to gomp-4_0-branch, r226970, <http://news.gmane.org/find-root.php?message_id=%3C55CB9109.6030202%40codesourcery.com%3E>, the following regressions are resolved (thanks!): > PASS: libgomp.oacc-fortran/declare-1.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O0 (test for excess errors) > [-PASS:-]{+FAIL:+} libgomp.oacc-fortran/declare-1.f90 > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 -O0 execution test > PASS: libgomp.oacc-fortran/declare-1.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O1 (test for excess errors) > [-PASS:-]{+FAIL:+} libgomp.oacc-fortran/declare-1.f90 > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 -O1 execution test > PASS: libgomp.oacc-fortran/declare-1.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O2 (test for excess errors) > [-PASS:-]{+FAIL:+} libgomp.oacc-fortran/declare-1.f90 > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 -O2 execution test > PASS: libgomp.oacc-fortran/declare-1.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O3 -fomit-frame-pointer (test for excess errors) > [-PASS:-]{+FAIL:+} libgomp.oacc-fortran/declare-1.f90 > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 -O3 -fomit-frame-pointer > execution test > PASS: libgomp.oacc-fortran/declare-1.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O3 -fomit-frame-pointer -funroll-loops (test for excess > errors) > [-PASS:-]{+FAIL:+} libgomp.oacc-fortran/declare-1.f90 > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 -O3 -fomit-frame-pointer > -funroll-loops execution test > PASS: libgomp.oacc-fortran/declare-1.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O3 -fomit-frame-pointer -funroll-all-loops > -finline-functions (test for excess errors) > [-PASS:-]{+FAIL:+} libgomp.oacc-fortran/declare-1.f90 > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 -O3 -fomit-frame-pointer > -funroll-all-loops -finline-functions execution test > PASS: libgomp.oacc-fortran/declare-1.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O3 -g (test for excess errors) > [-PASS:-]{+FAIL:+} libgomp.oacc-fortran/declare-1.f90 > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 -O3 -g execution test > PASS: libgomp.oacc-fortran/declare-1.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -Os (test for excess errors) > [-PASS:-]{+FAIL:+} libgomp.oacc-fortran/declare-1.f90 > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 -Os execution test ..., but the following ones remain to be addressed -- could somebody look into this, please? Especially the timeouts are very annoying. Tests that now reproducibly XPASS instead of XFAIL should be verified, and the XFAIL marker removed. > [-PASS:-]{+FAIL: gfortran.dg/goacc/modules.f95 -O (internal compiler > error)+} > {+FAIL:+} gfortran.dg/goacc/modules.f95 -O (test for excess errors) > > PASS: libgomp.oacc-c/../libgomp.oacc-c-c++-common/parallel-loop-1.c > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 (test for excess errors) > [-XFAIL:-]{+XPASS:+} > libgomp.oacc-c/../libgomp.oacc-c-c++-common/parallel-loop-1.c > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test > > PASS: libgomp.oacc-c/../libgomp.oacc-c-c++-common/reduction-4.c > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 (test for excess errors) > {+WARNING: program timed out.+} > XFAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/reduction-4.c > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test > > PASS: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/parallel-loop-1.c > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 (test for excess errors) > [-XFAIL:-]{+XPASS:+} > libgomp.oacc-c++/../libgomp.oacc-c-c++-common/parallel-loop-1.c > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test > > PASS: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/reduction-4.c > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 (test for excess errors) > {+WARNING: program timed out.+} > XFAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/reduction-4.c > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test > > PASS: libgomp.oacc-fortran/lib-13.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O0 (test for excess errors) > [-PASS:-]{+FAIL:+} libgomp.oacc-fortran/lib-13.f90 > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 -O0 execution test > PASS: libgomp.oacc-fortran/lib-13.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O1 (test for excess errors) > [-PASS:-]{+FAIL:+} libgomp.oacc-fortran/lib-13.f90 > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 -O1 execution test > PASS: libgomp.oacc-fortran/lib-13.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O2 (test for excess errors) > PASS: libgomp.oacc-fortran/lib-13.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O2 execution test > PASS: libgomp.oacc-fortran/lib-13.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O3 -fomit-frame-pointer (test for excess errors) > PASS: libgomp.oacc-fortran/lib-13.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O3 -fomit-frame-pointer execution test > PASS: libgomp.oacc-fortran/lib-13.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O3 -fomit-frame-pointer -funroll-loops (test for excess > errors) > [-PASS:-]{+FAIL:+} libgomp.oacc-fortran/lib-13.f90 > -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 -O3 -fomit-frame-pointer > -funroll-loops execution test > PASS: libgomp.oacc-fortran/lib-13.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O3 -fomit-frame-pointer -funroll-all-loops > -finline-functions (test for excess errors) > PASS: libgomp.oacc-fortran/lib-13.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O3 -fomit-frame-pointer -funroll-all-loops > -finline-functions execution test > PASS: libgomp.oacc-fortran/lib-13.f90 -DACC_DEVICE_TYPE_nvidia=1 > -DACC_MEM_SHARED=0 -O3 -g (test for excess errors) Grüße, Thomas
signature.asc
Description: PGP signature
