Hi! On Mon, 17 Aug 2015 06:46:32 -0700, Gary Funck <g...@intrepid.com> wrote: > I'm working on a patch set for GUPC, and as part of that work, > I may have a couple changes to trunk that will improve the fit > with the GUPC changes. Here's one in configure.ac. > > At the moment, there is a check to see if $enable_libgom > is not set, followed by a case statement which adds > libgomp to $noconfigdirs on non POSIX-like OS's.
Hmm...
> We'd like to re-use that logic for libgupc,
> which has a similar requirement and propose this
> re-factoring for trunk.
> --- configure.ac (revision 226928)
> +++ configure.ac (working copy)
> @@ -529,9 +529,8 @@ if test x$enable_static_libjava != xyes
> fi
> AC_SUBST(EXTRA_CONFIGARGS_LIBJAVA)
>
> -# Enable libgomp by default on hosted POSIX systems, and a few others.
> -if test x$enable_libgomp = x ; then
> - case "${target}" in
> +posix_like_os="yes"
> +case "${target}" in
> *-*-linux* | *-*-gnu* | *-*-k*bsd*-gnu | *-*-kopensolaris*-gnu)
> ;;
> *-*-netbsd* | *-*-freebsd* | *-*-openbsd* | *-*-dragonfly*)
> @@ -543,9 +542,14 @@ if test x$enable_libgomp = x ; then
> nvptx*-*-*)
> ;;
> *)
> - noconfigdirs="$noconfigdirs target-libgomp"
> - ;;
> - esac
> + posix_like_os="no"
> + ;;
> +esac
Even if applicable regarding the libgomp configuration (because
nvptx-none has its own libgomp "port": libgomp/config/nvptx/), it seems a
bit strange to qualify nvptx-none as a POSIX-like system.
> +
> +# Enable libgomp by default on POSIX hosted systems.
> +if test x$enable_libgomp = x && test $posix_like_os = "no" ; then
> + # Disable libgomp on non POSIX hosted systems.
> + noconfigdirs="$noconfigdirs target-libgomp"
> fi
So, we'll have to see whether that applies to libgupc for nvptx-none,
too.
Grüße,
Thomas
signature.asc
Description: PGP signature
