On Aug 17, 2015, Andreas Schwab <sch...@linux-m68k.org> wrote: > Alexandre Oliva <aol...@redhat.com> writes: >> Would you be so kind as to give it a spin on a m68k native? TIA,
> I tried it on ia64, and it falls flat on the floor. Doh, I see a logic flaw in the patch I posted. The hunk in assign_parm_setup_stack that looked like this: + if (from_expand) + gcc_assert (GET_MODE (from_expand) == GET_MODE (data->entry_parm)); + else if (!parm_in_unassigned_mem_p (parm, from_expand)) + data->stack_parm = from_expand; should look like this: + if (from_expand) + gcc_assert (GET_MODE (from_expand) == GET_MODE (data->entry_parm)); + if (from_expand && !parm_in_unassigned_mem_p (parm, from_expand)) + data->stack_parm = from_expand; I'll give it some more testing before submitting a formal patch. Meanwhile, thanks for confirming the m68k issues are fixed by that one; this one shouldn't regress them; it would only fix the unintended crashes. -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer
