This commits the patch from https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00663.html and adds tests for all the mutex types.
Eelis, thanks for the patch. Please CC the libstdc++ list for all libstdc++ patches, I don't subscribe to gcc-patches and only saw your mail because Ville brought it to my attention. Tested ppc64le-linux, committed to trunk.
commit 88dda918ab3602d1fb9ba7fe6454211d02160f92 Author: Jonathan Wakely <jwak...@redhat.com> Date: Thu Aug 13 14:44:11 2015 +0100 * testsuite/30_threads/mutex/unlock/2.cc: New. * testsuite/30_threads/recursive_mutex/unlock/2.cc: New. * testsuite/30_threads/recursive_timed_mutex/unlock/2.cc: New. * testsuite/30_threads/shared_mutex/unlock/1.cc: New. * testsuite/30_threads/shared_timed_mutex/unlock/1.cc: New. * testsuite/30_threads/timed_mutex/unlock/2.cc: New. diff --git a/libstdc++-v3/testsuite/30_threads/mutex/unlock/2.cc b/libstdc++-v3/testsuite/30_threads/mutex/unlock/2.cc new file mode 100644 index 0000000..02464cd --- /dev/null +++ b/libstdc++-v3/testsuite/30_threads/mutex/unlock/2.cc @@ -0,0 +1,43 @@ +// { dg-do run { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* *-*-solaris* *-*-cygwin *-*-darwin* powerpc-ibm-aix* } } +// { dg-options " -std=gnu++11 -pthread" { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* powerpc-ibm-aix* } } +// { dg-options " -std=gnu++11 -pthreads" { target *-*-solaris* } } +// { dg-options " -std=gnu++11 " { target *-*-cygwin *-*-darwin* } } +// { dg-require-cstdint "" } +// { dg-require-gthreads "" } + +// Copyright (C) 2015 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +#include <mutex> +#include <thread> + +using mutex_type = std::mutex; + +mutex_type m; + +void f() +{ + std::lock_guard<mutex_type> l(m); +} + +int main() +{ + std::thread t1(f); + std::thread t2(f); + t1.join(); + t2.join(); +} diff --git a/libstdc++-v3/testsuite/30_threads/recursive_mutex/unlock/2.cc b/libstdc++-v3/testsuite/30_threads/recursive_mutex/unlock/2.cc new file mode 100644 index 0000000..68bd5d0 --- /dev/null +++ b/libstdc++-v3/testsuite/30_threads/recursive_mutex/unlock/2.cc @@ -0,0 +1,43 @@ +// { dg-do run { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* *-*-solaris* *-*-cygwin *-*-darwin* powerpc-ibm-aix* } } +// { dg-options " -std=gnu++11 -pthread" { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* powerpc-ibm-aix* } } +// { dg-options " -std=gnu++11 -pthreads" { target *-*-solaris* } } +// { dg-options " -std=gnu++11 " { target *-*-cygwin *-*-darwin* } } +// { dg-require-cstdint "" } +// { dg-require-gthreads "" } + +// Copyright (C) 2015 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +#include <mutex> +#include <thread> + +using mutex_type = std::recursive_mutex; + +mutex_type m; + +void f() +{ + std::lock_guard<mutex_type> l(m); +} + +int main() +{ + std::thread t1(f); + std::thread t2(f); + t1.join(); + t2.join(); +} diff --git a/libstdc++-v3/testsuite/30_threads/recursive_timed_mutex/unlock/2.cc b/libstdc++-v3/testsuite/30_threads/recursive_timed_mutex/unlock/2.cc new file mode 100644 index 0000000..ac51f43 --- /dev/null +++ b/libstdc++-v3/testsuite/30_threads/recursive_timed_mutex/unlock/2.cc @@ -0,0 +1,43 @@ +// { dg-do run { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* *-*-solaris* *-*-cygwin *-*-darwin* powerpc-ibm-aix* } } +// { dg-options " -std=gnu++11 -pthread" { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* powerpc-ibm-aix* } } +// { dg-options " -std=gnu++11 -pthreads" { target *-*-solaris* } } +// { dg-options " -std=gnu++11 " { target *-*-cygwin *-*-darwin* } } +// { dg-require-cstdint "" } +// { dg-require-gthreads "" } + +// Copyright (C) 2015 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +#include <mutex> +#include <thread> + +using mutex_type = std::recursive_timed_mutex; + +mutex_type m; + +void f() +{ + std::lock_guard<mutex_type> l(m); +} + +int main() +{ + std::thread t1(f); + std::thread t2(f); + t1.join(); + t2.join(); +} diff --git a/libstdc++-v3/testsuite/30_threads/shared_mutex/unlock/1.cc b/libstdc++-v3/testsuite/30_threads/shared_mutex/unlock/1.cc new file mode 100644 index 0000000..e091591 --- /dev/null +++ b/libstdc++-v3/testsuite/30_threads/shared_mutex/unlock/1.cc @@ -0,0 +1,43 @@ +// { dg-do run { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* *-*-solaris* *-*-cygwin *-*-darwin* powerpc-ibm-aix* } } +// { dg-options " -std=gnu++17 -pthread" { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* powerpc-ibm-aix* } } +// { dg-options " -std=gnu++17 -pthreads" { target *-*-solaris* } } +// { dg-options " -std=gnu++17 " { target *-*-cygwin *-*-darwin* } } +// { dg-require-cstdint "" } +// { dg-require-gthreads "" } + +// Copyright (C) 2015 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +#include <shared_mutex> +#include <thread> + +using mutex_type = std::shared_mutex; + +mutex_type m; + +void f() +{ + std::lock_guard<mutex_type> l(m); +} + +int main() +{ + std::thread t1(f); + std::thread t2(f); + t1.join(); + t2.join(); +} diff --git a/libstdc++-v3/testsuite/30_threads/shared_timed_mutex/unlock/1.cc b/libstdc++-v3/testsuite/30_threads/shared_timed_mutex/unlock/1.cc new file mode 100644 index 0000000..b6ca4bf --- /dev/null +++ b/libstdc++-v3/testsuite/30_threads/shared_timed_mutex/unlock/1.cc @@ -0,0 +1,43 @@ +// { dg-do run { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* *-*-solaris* *-*-cygwin *-*-darwin* powerpc-ibm-aix* } } +// { dg-options " -std=gnu++14 -pthread" { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* powerpc-ibm-aix* } } +// { dg-options " -std=gnu++14 -pthreads" { target *-*-solaris* } } +// { dg-options " -std=gnu++14 " { target *-*-cygwin *-*-darwin* } } +// { dg-require-cstdint "" } +// { dg-require-gthreads "" } + +// Copyright (C) 2015 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +#include <shared_mutex> +#include <thread> + +using mutex_type = std::shared_timed_mutex; + +mutex_type m; + +void f() +{ + std::lock_guard<mutex_type> l(m); +} + +int main() +{ + std::thread t1(f); + std::thread t2(f); + t1.join(); + t2.join(); +} diff --git a/libstdc++-v3/testsuite/30_threads/timed_mutex/unlock/2.cc b/libstdc++-v3/testsuite/30_threads/timed_mutex/unlock/2.cc new file mode 100644 index 0000000..10fdc53 --- /dev/null +++ b/libstdc++-v3/testsuite/30_threads/timed_mutex/unlock/2.cc @@ -0,0 +1,43 @@ +// { dg-do run { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* *-*-solaris* *-*-cygwin *-*-darwin* powerpc-ibm-aix* } } +// { dg-options " -std=gnu++11 -pthread" { target *-*-freebsd* *-*-dragonfly* *-*-netbsd* *-*-linux* *-*-gnu* powerpc-ibm-aix* } } +// { dg-options " -std=gnu++11 -pthreads" { target *-*-solaris* } } +// { dg-options " -std=gnu++11 " { target *-*-cygwin *-*-darwin* } } +// { dg-require-cstdint "" } +// { dg-require-gthreads "" } + +// Copyright (C) 2015 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// <http://www.gnu.org/licenses/>. + +#include <mutex> +#include <thread> + +using mutex_type = std::timed_mutex; + +mutex_type m; + +void f() +{ + std::lock_guard<mutex_type> l(m); +} + +int main() +{ + std::thread t1(f); + std::thread t2(f); + t1.join(); + t2.join(); +} commit 021b06678fd9821dde50669044f682a03bb57fd5 Author: Jonathan Wakely <jwak...@redhat.com> Date: Thu Aug 13 14:34:51 2015 +0100 2015-08-13 Eelis van der Weegen <ee...@eelis.net> * include/std/shared_mutex (shared_mutex::unlock()): Fix typo. diff --git a/libstdc++-v3/include/std/shared_mutex b/libstdc++-v3/include/std/shared_mutex index 0a893ee..ae5f199 100644 --- a/libstdc++-v3/include/std/shared_mutex +++ b/libstdc++-v3/include/std/shared_mutex @@ -331,7 +331,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION void lock() { _M_impl.lock(); } bool try_lock() { return _M_impl.try_lock(); } - void unlock() { _M_impl.try_lock(); } + void unlock() { _M_impl.unlock(); } // Shared ownership