On Tue, Jul 26, 2011 at 10:36 AM, Uros Bizjak <ubiz...@gmail.com> wrote: > On Tue, Jul 26, 2011 at 7:31 PM, H.J. Lu <hjl.to...@gmail.com> wrote: > >>>> This patch fixes PIC with external symbol and updates >>>> x86_64_immediate_operand/x86_64_zext_immediate_operand/x86_64_movabs_operand >>>> for x32. >>> >>>> 2011-07-26 H.J. Lu <hongjiu...@intel.com> >>>> >>>> PR target/49853 >>>> * config/i386/i386.c (ix86_expand_move): Call convert_to_mode >>>> on legitimize_tls_address return if needed. Allow ptr_mode for >>>> symbolic operand with PIC. >>> >>> Eh... half of your patch is just an unnecessary rename of a temporary >>> variable. See attached patch for a cleaned-up version. >> >> It looks good to me. Can you check it in? > > Please, can you test it on x32 first? I will commit it after > bootstrap/regtest finish. >
It may need other changes for TLS support. I can update it after your change is checked in. -- H.J.