Hi, Benedikt.

It looks pretty good.  I'd just hesitate to go about defining which cores
benefit from this by default, IIUC.
Cheers,

-- 
Evandro Menezes                              Austin, TX

> -----Original Message-----
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org]
On
> Behalf Of Benedikt Huber
> Sent: Friday, July 31, 2015 12:06
> To: gcc-patches@gcc.gnu.org
> Cc: philipp.toms...@theobroma-systems.com; venkataramanan.ku...@amd.com;
> pins...@gmail.com; e.mene...@samsung.com; kyrylo.tkac...@arm.com; Benedikt
> Huber
> Subject: [PATCH v4][aarch64] Implemented reciprocal square root (rsqrt)
> estimation in -ffast-math
> 
> This fourth revision of the patch:
>  * fixes an error in the docs.
>  * uses gen_rsqrt* functions.
>  * uses extra_tuning_flags.
> 
> Ok for check in.
> 
> Benedikt Huber (1):
>   2015-07-31  Benedikt Huber  <benedikt.hu...@theobroma-systems.com>
>           Philipp Tomsich  <philipp.toms...@theobroma-systems.com>
> 
>  gcc/ChangeLog                                      |  21 ++++
>  gcc/config/aarch64/aarch64-builtins.c              | 104
> ++++++++++++++++++++
>  gcc/config/aarch64/aarch64-opts.h                  |   7 ++
>  gcc/config/aarch64/aarch64-protos.h                |   2 +
>  gcc/config/aarch64/aarch64-simd.md                 |  27 ++++++
>  gcc/config/aarch64/aarch64-tuning-flags.def        |   1 +
>  gcc/config/aarch64/aarch64.c                       | 106
> +++++++++++++++++++-
>  gcc/config/aarch64/aarch64.md                      |   3 +
>  gcc/config/aarch64/aarch64.opt                     |   8 ++
>  gcc/doc/invoke.texi                                |  19 ++++
>  gcc/testsuite/gcc.target/aarch64/rsqrt-asm-check.c |  63 ++++++++++++
>  gcc/testsuite/gcc.target/aarch64/rsqrt.c           | 107
> +++++++++++++++++++++
>  12 files changed, 463 insertions(+), 5 deletions(-)  create mode 100644
> gcc/testsuite/gcc.target/aarch64/rsqrt-asm-check.c
>  create mode 100644 gcc/testsuite/gcc.target/aarch64/rsqrt.c
> 
> --
> 1.9.1

Reply via email to