On 07/14/2015 09:18 AM, Marek Polacek wrote:
Code such as "if (i == i)" is hardly ever desirable, so we should be able to warn about this to prevent dumb mistakes.
I haven't tried the patch or even studied it very carefully but I wonder if this is also the case when i is declared volatile. I.e., do we want to issue a warning there? (If we do, the text of the warning would need to be adjusted in those cases since the expression need not evaluate to true.) Martin