Hi, thanks for the review.
On 07/18/2011 03:19 PM, Richard Earnshaw wrote: > On 18/07/11 12:09, Tom de Vries wrote: >> Hi, >> >> PR43597 was fixed by >> http://gcc.gnu.org/viewcvs?view=revision&revision=172032. >> >> This patch adds a testcase. >> >> OK for trunk? >> >> Thanks, >> - Tom >> >> 2011-07-18 Tom de Vries <t...@codesourcery.com> >> >> PR target/43597 >> * gcc.target/arm/pr43597.c: New test. >> >> > > No, don't pass -mthumb through dg-options unless you're using something > like require-effective-target. > OK, I see. > In this case the post-compile tests are all gated on thumb2. So why not > make the whole test just require arm_thumb2_ok? > > R. > Done. OK for trunk? Thanks, - Tom 2011-07-25 Tom de Vries <t...@codesourcery.com> PR target/43597 * gcc.target/arm/pr43597.c: New test.
Index: gcc.target/arm/pr43597.c =================================================================== --- gcc.target/arm/pr43597.c (revision 0) +++ gcc.target/arm/pr43597.c (revision 0) @@ -0,0 +1,28 @@ +/* { dg-do assemble } */ +/* { dg-options "-Os -save-temps -mthumb" } */ +/* { dg-require-effective-target arm_thumb2_ok } */ + +extern int bar (); +extern void bar2 (int); + +int +foo4 () +{ + int result = 0; + int f = -1; + f = bar (); + if (f < 0) + { + result = 1; + goto bail; + } + bar (); + bail: + bar2 (f); + return result; +} + +/* { dg-final { scan-assembler-times "sub" 1 } } */ +/* { dg-final { scan-assembler-times "cmp" 0 } } */ +/* { dg-final { object-size text <= 30 } } */ +/* { dg-final { cleanup-saved-temps "pr43597" } } */