On 07/17/2015 06:37 AM, Kyrill Tkachov wrote:
Hi Sandra,
On 17/07/15 04:21, Sandra Loosemore wrote:
On 07/16/2015 09:21 AM, Kyrill Tkachov wrote:
Hi all,
This patch adds the documentation for the AArch64 target attributes and
pragmas.
Ok for trunk?
The content looks OK, but I have a bunch of nit-picky comments about
grammar, typos, markup, etc....
Thanks for the detailed feedback!
Here's an updated version.
There are still a few things I previously noted, but that you missed in
preparing this version.
+the same behavior as that of the command line option
s/command line option/command-line option/g
https://gcc.gnu.org/codingconventions.html#Spelling
+where @var{@var{attr-string}} is one of the attribute strings specified above.
@var{@var{...}} should be @code{@var{...}}, I think.
+Note that CPU tuning options and attributes such as the @option{-mcpu=},
+@option{-mtune=} do not inhibit inlining unless the CPU specified by the
+@option{-mcpu=} option or the @option{cpu=} attribute conflicts with the
s/@option{cpu=} attribute/@code{cpu=} attribute/
+@smallexample
+#pragma GCC target("<string>")
s/<string>/@var{string}/
+@end smallexample
+
+where @code{@var{string}} can be any string accepted as an AArch64 target
+attribute. @xref{AArch64 Function Attributes}, for more details
+on the permissible values of @code{<string>}.
Here too.
OK with those things fixed.
-Sandra
