On 07/11/2015 12:53 AM, Nathan Sidwell wrote:
I'mm working through the mkoffload machinery. mkoffload.c emits a C
file, and the quoting in the source is quite confusing. This patch
introduces a quoting macro 'Q' that allows one to write raw C to be
stringized and written out.
ok? (more cleanups to follow)
The quoting is fairly standard and used throughout gcc, and I guess I'm
kind of used to seeing it - the patch would make things inconsistent
with everything else. It's also nonobvious and probably unintentional
that indentation and linebreaks get lost in some places in the output
when the patch is applied - the following is emitted as a single line:
extern void *__OFFLOAD_TABLE__[]; static __attribute__((constructor))
void init (void) { GOMP_offload_register (__OFFLOAD_TABLE__, 5,
&target_data); }
So, I'm sorry - not a fan of this.
Bernd
