On 06/29/2015 09:48 AM, Manuel López-Ibáñez wrote:
Wunused-parameter warnings are given from cgraph::finalize_function,
which is the middle-end. This is an oddity compared to other
-Wunused-* warnings. Moreover, Fortran has its own definition of
-Wunused-parameter that conflicts with the middle-end definition.

This patch moves the middle-end part of Wunused-parameter to the C/C++
FEs. I'm not sure if other FEs expected this warning to work. If so,
they do not seem to test for it. Ada, for example, explicitly disables
it.

This also fixes [fortran/66605] -Wunused-parameter causes internal
compiler error with gfortran 5.1.0.

Bootstrapped & regression tested on x86_64-linux-gnu with languages
c,c++,objc,fortran,ada,obj-c++

OK?


gcc/ChangeLog:

2015-06-28  Manuel López-Ibáñez  <m...@gcc.gnu.org>

     PR fortran/66605
     * cgraphunit.c (cgraph_node::finalize_function): Do not call
     do_warn_unused_parameter.
     * function.c (do_warn_unused_parameter): Move from here.
     * function.h (do_warn_unused_parameter): Do not declare.

gcc/c-family/ChangeLog:

2015-06-28  Manuel López-Ibáñez  <m...@gcc.gnu.org>

     PR fortran/66605
    * c-common.c (do_warn_unused_parameter): Move here.
     * c-common.h (do_warn_unused_parameter): Declare.

gcc/ada/ChangeLog:

2015-06-28  Manuel López-Ibáñez  <m...@gcc.gnu.org>

     PR fortran/66605
    * gcc-interface/misc.c (gnat_post_options): No need to disable
     warn_unused_parameter anymore.

gcc/cp/ChangeLog:

2015-06-28  Manuel López-Ibáñez  <m...@gcc.gnu.org>

     PR fortran/66605
    * decl.c (finish_function): Call do_warn_unused_parameter.

gcc/testsuite/ChangeLog:

2015-06-28  Manuel López-Ibáñez  <m...@gcc.gnu.org>

     PR fortran/66605
    * gfortran.dg/wunused-parameter.f90: New test.

gcc/c/ChangeLog:

2015-06-28  Manuel López-Ibáñez  <m...@gcc.gnu.org>

     PR fortran/66605
    * c-decl.c (finish_function): Call do_warn_unused_parameter.

OK for the trunk after fixing the whitespace vs tabs issues in the ChangeLog entries. Nitty, I know :-)

Jeff

Reply via email to