On 07/06/2015 09:38 AM, Michael Matz wrote:
Hi,
On Sun, 5 Jul 2015, Prathamesh Kulkarni wrote:
Hi,
The attached patches flatten cfgloop.h.
patch-1.diff moves around prototypes and structures to respective header-files.
patch-2.diff (mostly auto-generated) replicates cfgloop.h includes in c files.
Bootstrapped and tested on x86_64-unknown-linux-gnu with all front-ends.
Built on all targets using config-list.mk.
I left includes in cfgloop.h commented with #if 0 ... #endif.
OK for trunk ?
Does nobody else think that header files for one or two prototypes are
fairly silly?
I think it has its uses, but we also have the vast majority of the
"problem" includes resolved. I didn't remember that these older patches
were still doing anything other than moving includes.
I'm thinking we need to sit back and do the rebuilding and see where we
land after I do the include reduction.
Over the next couple of days I'm planning to submit some
flattening/re-modulizing patches. so maybe we ought to hold off on this
for now and maybe then revisit parts of this. Some of the includes in
cfgloop.h are impacted and become parts of a backend module header..
Andrew
