On Tue, 2015-06-23 at 13:17 -0600, Jeff Law wrote: > On 06/10/2015 09:24 AM, David Malcolm wrote: > > gcc/unittests/ChangeLog: > > * test-cfg.c: New file. > > --- > > gcc/unittests/test-cfg.c | 319 > > +++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 319 insertions(+) > > create mode 100644 gcc/unittests/test-cfg.c > So this one would be a great place to check that the dominator code does > something sensible if there's unreachable nodes in the CFG or the > post-dominator code does something sensible with infinite loops, etc. > > I don't necessarily expect you to do this, just pointing it out. > > Just a nit, I noticed this included rtl.h, which seems a bit odd. Are > those #includes relatively minimal or are they in need to cleanup?
Yes, they need to be cleaned up (I #included stuff until it compiled). My plan is to minimize what these files #include once the more controversial aspects of this patchkit are resolved - given that the header files are in a state of flux, any minimization I attempt now is likely to be out-of-date.
