On Mon, Jun 22, 2015 at 5:56 PM, Alex Velenko <alex.vele...@arm.com> wrote:
> On 20/05/15 21:14, Joseph Myers wrote:
>>
>> Again, the condition you propose to add doesn't make sense.  arm_arch_X_ok
>> is only appropriate for tests using an explicit -march=X.  Testing with
>> -march=armv7* should automatically skip this test anyway because it would
>> cause arm_thumb1_ok to fail.
>>
>
> Hi,
>
> I adjusted the patch to skip execution split-live-ranges-for-shrink-wrap.c
> with explicitly specified -march=armv4t and provide -march=armv5t flag =
> for
> arm_arch_v5t_ok targets.
>
> Is patch ok?
>
> Alex
>
> gcc/testsuite
>
> 2015-06-22  Alex Velenko  <alex.vele...@arm.com>
>
>          * gcc.target/arm/split-live-ranges-for-shrink-wrap.c (dg-skip-if):
>         Skip -march=armv4t.
>         (dg-additional-options): Set armv5t flag.
>
> diff --git
> a/gcc/testsuite/gcc.target/arm/split-live-ranges-for-shrink-wrap.c
> b/gcc/testsuite/gcc.target/arm/split-live-ranges-for-shrink-wrap.c
> index e36000b..3cb93dc 100644
> --- a/gcc/testsuite/gcc.target/arm/split-live-ranges-for-shrink-wrap.c
> +++ b/gcc/testsuite/gcc.target/arm/split-live-ranges-for-shrink-wrap.c
> @@ -1,6 +1,8 @@
>   /* { dg-do assemble } */
>   /* { dg-options "-mthumb -Os -fdump-rtl-ira " }  */
>   /* { dg-require-effective-target arm_thumb1_ok } */
> +/* { dg-skip-if "do not test on armv4t" { *-*-* } { "-march=armv4t" } } =
> */
> +/* { dg-additional-options "-march=armv5t" {target arm_arch_v5t_ok} } */
>
>   int foo (char *, char *, int);
>   int test (int d, char * out, char *in, int len)


OK - please watch out for any multilibs fallout and apply this.

Ramana
>
> --------------1.8.1.2--
>

Reply via email to