On Tue, Jun 23, 2015 at 12:38 AM, Jason Merrill <ja...@redhat.com> wrote: > On 06/15/2015 02:32 PM, Patrick Palka wrote: >> >> On Mon, Jun 15, 2015 at 2:05 PM, Jason Merrill <ja...@redhat.com> wrote: >>> >>> Any reason not to use grow_tree_vec? >> >> >> Doing so causes a lot of ICEs in the testsuite. I think it's because >> grow_tree_vec invalidates the older parameter_vec which some trees may >> still be holding a reference to in their DECL_TEMPLATE_PARMS field. > > > Hmm, that's unfortunate, as doing it this way means we get a bunch of > garbage TREE_VECs in the process. But I guess the patch is OK as is.
Yeah, though I can't think of a simple way to work around this -- any solution I think of seems to require a change in the representation of current_template_parms, something that would be quite invasive.... Will commit the patch shortly. > > Jason >
