Hi Uros

After bootstrap testing and regression testing on bdver4 machine.  I committed 
the back port on GCC 5 branch  at 

https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=224603

Checked with Richard as well before proceeding.

Regards,
Venkat.

> -----Original Message-----
> From: Uros Bizjak [mailto:ubiz...@gmail.com]
> Sent: Friday, June 12, 2015 4:02 PM
> To: Kumar, Venkataramanan
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] [X86_64]: Add support for MONITORX and MWAITX ISA
> 
> On Fri, Jun 12, 2015 at 12:27 PM, Kumar, Venkataramanan
> <venkataramanan.ku...@amd.com> wrote:
> 
> >> > Ok for trunk ?
> >>
> >> OK for mainline with a small improvement below.
> >>
> >> +    case IX86_BUILTIN_MONITORX:
> >> +      arg0 = CALL_EXPR_ARG (exp, 0);
> >> +      arg1 = CALL_EXPR_ARG (exp, 1);
> >> +      arg2 = CALL_EXPR_ARG (exp, 2);
> >> +      op0 = expand_normal (arg0);
> >> +      op1 = expand_normal (arg1);
> >> +      op2 = expand_normal (arg2);
> >> +      if (!REG_P (op0))
> >> + op0 = ix86_zero_extend_to_Pmode (op0);
> >> +      if (!REG_P (op1))
> >> + op1 = copy_to_mode_reg (SImode, op1);
> >> +      if (!REG_P (op2))
> >> + op2 = copy_to_mode_reg (SImode, op2);
> >> +      emit_insn (ix86_gen_monitorx (op0, op1, op2));
> >> +      return 0;
> >>
> >> Please merge the above with existing IX86_BUILTIN_MONITOR. You can
> >> use emit_insn (fcode == IX86_BUILTIN_MONITOR
> >>   ? ix86_gen_monitor (...)
> >>   : ix86_gen_monitorx (...));
> >>
> >> Thanks,
> >> Uros.
> >
> > Thank you. I committed the patch along with your suggestion.
> > Ref: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=224414
> >
> > We would like to get this ISA support into next release compiler based on
> GCC 5.
> >
> > Is this ok for gcc-5-branch?
> 
> Should be OK (the branch has not diverged too much from the trunk yet),
> but please wait a week to see if any problem arises in the trunk, and to give
> some time for release managers to eventually object.
> 
> Thanks,
> Uros.

Reply via email to