On June 10, 2015 5:34:47 PM GMT+02:00, Jakub Jelinek <ja...@redhat.com> wrote: >On Wed, Jun 10, 2015 at 11:24:41AM -0400, David Malcolm wrote: >> I picked the Google Test framework: >> http://code.google.com/p/googletest/ > >I must say I'm not very excited about using this, it won't integrate >very well with dejagnu, whether talking about results (will it provide >some *.log/*.sum file with FAIL/XFAIL/PASS/XPASS etc. lines?), choosing >what options to use, e.g. global >RUNTESTFLAGS='--target_board=unix/\{-m32,-m64\}' >to test everything twice for 32-bit and 64-bit, will that run just >all unittests twice the same?, or possibility to run a subset of tests >etc. >E.g. for asan.exp testing, I just wrote a gtest emulation using >dejagnu, see testsuite/g++.dg/asan/dejagnu-gtest.h and >testsuite/lib/asan-dg.exp, but that was mainly meant for cases where >many routines are expected to crash the process. If in unittests >you are doing only operations that aren't meant to take everything down >or >if they crash, it is ok if it breaks the whole unit testing, >then perhaps it can be run as a single process and thus a single >dejagnu >job, and just let the wrapper parse the output and transform it. > >Also, no matter what testsuite framework is used, including any >headers before #include "config.h" line is a big no-no.
Agreed. I think it is reasonable to instead do like the two existing tests - piggy back on a plugin testcase. Richard. > Jakub
