On Tue, Apr 28, 2015 at 10:37 AM, Richard Biener <rguent...@suse.de> wrote: > On Fri, 17 Apr 2015, Jakub Jelinek wrote: > >> On Fri, Apr 17, 2015 at 12:32:03PM +0200, Richard Biener wrote: >> > So Jakub says that using comp_unit_die () for the context of the stub >> > DIE is wrong and he is of course right. The following adjusted patch >> > uses the correct context, but only if we already have a DIE for it, >> > otherwise we drop the DW_TAG_GNU_call_site ref on the floor. >> >> I'd mention that this last line doesn't match what the code does, >> because in reality it just means that we drop the DW_AT_abstract_origin >> of DW_TAG_GNU_call_site. That really means just that the debugger won't >> know what function is called at that point, as if it were e.g. >> an indirect jump with unknown target that is not preserved in any register >> across the call), but e.g. all the guarantees that we cover all the calls >> still holds. > > Ping.
Ping again - I'd really like to fix this most-common LTO ICE on the 4.8 branch. I'm fine with guarding all the code with in_lto_p if you require me to do that. So - any further guidance please? For reference, the last patch was at https://gcc.gnu.org/ml/gcc-patches/2015-04/msg00862.html Thanks, Richard. > Richard.
