On Wed, May 27, 2015 at 10:09 PM, Richard Henderson <r...@redhat.com> wrote: > On 05/27/2015 12:40 PM, Uros Bizjak wrote: >> Also, fix function operand type to match the operand type. > > Why do you believe op to be of type "long"? > Certainly man 2 futex doesn't say that.
In libgomp/config/linux/wait.h, we have: extern long int gomp_futex_wait, gomp_futex_wake; These are passed in libgomp/config/linux/x86/futex.h as: long res = sys_futex0 (addr, gomp_futex_wait, val); Considering that x86 is an ILP32 target, and looking at x86_64's sys_futex0 in libitm/config/linux/x86 I choose long here. If we want to follow futex manpage, we probably need to redefine gomp_futex_wait and gomp_futex_wake as a plain int. Uros.
