On May 20, 2015, Jason Merrill <ja...@redhat.com> wrote: > I want to explicitly pass -std=c++98 to the compiler used in building > stage 1. Does this seem like the right way to do that?
It certainly works, but I'm a bit concerned about its overriding the earlier choices of STAGE1_CXXFLAGS, that use CXXFLAGS or STAGE1_CFLAGS depending on whether or not C++ is being bootstrapped. Now, since GCC is in C++ nowadays, not bootstrapping C++ is not really possible, so it seems to make sense to just drop it. The top-level is shared with other projects written in C++, but this change would only impact them if they involved bootstrapping too, which AFAIK only GCC does. The only serious problem with the patch is that it changes Makefile.in, but not the corresponding part of Makefile.tpl from which it is generated. Ok with that change. Now, if you'd also update the comments just before it, that still suggest we build only C in stage1, that would be appreciated. Thanks, -- Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer
