Re: [patch] testsuite enable PIE tests on FreeBSD

[Jeff Law]

On 05/20/2015 11:04 AM, Andreas Tobler wrote:
Hi,
the attached patch enables some PIE tests on FreeBSD.

Ok for trunk?

Thanks,
Andreas

2015-05-20  Andreas Tobler  <andre...@gcc.gnu.org>

     * gcc.target/i386/pr32219-1.c: Enable test on FreeBSD.
     * gcc.target/i386/pr32219-2.c: Likewise.
     * gcc.target/i386/pr32219-3.c: Likewise.
     * gcc.target/i386/pr32219-4.c: Likewise.
     * gcc.target/i386/pr32219-5.c: Likewise.
     * gcc.target/i386/pr32219-6.c: Likewise
     * gcc.target/i386/pr32219-7.c: Likewise.
     * gcc.target/i386/pr32219-8.c: Likewise.
     * gcc.target/i386/pr39013-1.c: Likewise.
     * gcc.target/i386/pr39013-2.c: Likewise.
     * gcc.target/i386/pr64317.c: Likewise.
Wouldn't it be better to remove the target selector and instead add:

/* { dg-require-effective-target pie } */

In each of those tests?

While the net effect is the same today, it means there's only one place 
to change if another x86 target gains PIE support in the future.

Pre-approved using that style.
jeff