> -----Original Message----- > From: Steve Ellcey [mailto:sell...@imgtec.com] > Sent: Tuesday, May 12, 2015 12:51 PM > To: Kumar, Venkataramanan > Cc: Segher Boessenkool; Jeff Law (l...@redhat.com); gcc- > patc...@gcc.gnu.org; maxim.kuvyr...@linaro.org; Matthew Fortune; > Moore, Catherine > Subject: RE: [RFC]: Remove Mem/address type assumption in combiner > > On Tue, 2015-05-12 at 05:21 +0000, Kumar, Venkataramanan wrote: > > Hi Steve, > > > > Yes this is expected. As Segher pointed out, we need to change .md > > patterns in target to be based on shifts instead of mults. > > > > Regards, > > Venkat. > > Here is my patch to change this. I tested it with the mips-mti-linux-gnu and > mips-mti-elf targets and it fixed the MIPS specific tests that were scanning > for an lsa instruction and it also had no regressions. > > Since the lsa instruction was the only one using the 'y' operand code and my > change got rid of the only use of it, I removed it as part of this patch. > > Matthew or Catherine is this OK to checkin? > > 2015-05-12 Steve Ellcey <sell...@imgtec.com> > > * config/mips/mips.c (mips_print_operand): Remove 'y' operand > code. > * config/mips/mips.md (<GPR:d>lsa): Rewrite with shift operator. > * config/mips/predicates.md (const_immlsa_operand): Remove log > call. >
This is OK. Catherine
