On 04/30/2015 03:30 AM, Marek Polacek wrote:
Ping.

On Wed, Apr 22, 2015 at 05:24:43PM +0200, Marek Polacek wrote:
handle_cache_entry in tm_clone_hasher looks wrong: the condition
if (e != HTAB_EMPTY_ENTRY || e != HTAB_DELETED_ENTRY) is always true.  While
it could be fixed by just changing || into &&, I decided to follow suit and
do what we do in handle_cache_entry's elsewhere in the codebase.  I've fixed
a formatting issue below while at it.

Bootstrapped/regtested on x86_64-linux, ok for trunk?
I think this should also go into 5.1.

2015-04-22  Marek Polacek  <pola...@redhat.com>

        * varasm.c (handle_cache_entry): Fix logic.
OK. Though I do wonder if we should try to unify this with the other instances to avoid the useless duplication.

jeff

Reply via email to