Hi Julian! On Fri, 24 Apr 2015 18:13:08 +0100, Julian Brown <jul...@codesourcery.com> wrote: > On Thu, 23 Apr 2015 18:41:34 +0200 > Thomas Schwinge <tho...@codesourcery.com> wrote: > > On Wed, 22 Apr 2015 19:42:43 +0100, Julian Brown > > <jul...@codesourcery.com> wrote: > > > This patch is an attempt to fix some potential race conditions with > > > accesses to shared data structures from multiple concurrent threads > > > in libgomp's OpenACC entry points.
> > > Tests look OK (with offloading to NVidia PTX). > > > > How did you test to get some confidence in the locking being > > sufficient? > > Merely by running the existing tests and via inspection, sadly. I'm not > sure how much value we'd get from implementing an exhaustive threading > testsuite at this stage: I guess testcases will be easier to come by in > the future if/when people start to use e.g. OpenMP and OpenACC together. ;-) The poor person to be the first to actually exercise all that code... Thanks for your explanations and the rework. > Re-tested (libgomp), results look OK. > > OK to apply now? OK, thanks! Grüße, Thomas
pgp6oCMUj9Siy.pgp
Description: PGP signature
