On 04/22/2015 12:13 PM, David Malcolm wrote:
Conditional compilation was a major PITA when doing the rtx->rtx_insn *
work last year, so I'm very pleased to see these cleanups go in.
Yup. It also got in Andrew's way last year and we regularly see cases
where small patches which work fine on the mainstream architectures fail
to build in the lesser used architectures (particularly cc0 targets).
It's a whole class of problems I want to see slowly disappear.
glibc went through this process in their codebase for similar reasons,
but they had more to lose when they got it wrong -- IIRC they had a case
where exported ABI would differ as a result of conditionally compiled
code. Not good.
Jeff
